devon formatter not having same values like Sonar plugin

[rhobolic]

If I'm using the devon ide (devon4j) without touching everything I get issues in Sonar though I use the devon sonar plugin also without changes.

Problem description: As an example here is to take the checkstyle rule which is also part of devon java profile "Intendation". When I look into the profile I see the following configuration. But if I look into the formatter in the ide there is the following configuration Therefore Sonar is throwing an issue. There are also other issues like "Import order" or "Line length"

Expectation Devon ide, devon formatter and devon sonar plugin have the same values and work out of the box without throwing issues.

[hohwille]

@rhobolic thanks for reporting this bug. Indeed this is very odd and kind of frustrating. I am not sure why this happened. Indentation in devonfw has been 2 white spaces from the very beginning (even in oasp4j). After all the default rules and especially the whitespace rules for checkstyle are defined here: https://github.com/devonfw/sonar-devon4j-plugin/blob/3bd6482d1164e7d915ec4d10779eeda6235316fe/src/main/resources/com/devonfw/ide/sonarqube/common/rules/devon4j/devon4j.xml#L703

As we can see the parameters are simply wrong: https://github.com/devonfw/sonar-devon4j-plugin/blob/3bd6482d1164e7d915ec4d10779eeda6235316fe/src/main/resources/com/devonfw/ide/sonarqube/common/rules/devon4j/devon4j.xml#L729

I will simply change this and set the indentation to 2 instead of 4.

BTW:

If I'm using the devon ide (devon4j) without touching everything I get issues in Sonar though I use the devon sonar plugin also without changes.

As a lot of people seemed to get confused with devonfw artifacts here are some hints to match them properly:

• devonfw-ide is the tool to setup your local development environment: https://github.com/devonfw/ide#devonfw-ide - it is very generic and can be used for any kind of project (using Java, or .NET, or python, or NodeJS, or ...).
• devon4j is the Java stack of devonfw: https://github.com/devonfw/devon4j#devon4j
• sonar-devon4j-plugin is this repo with the sonar plugin for devon4j that you found perfectly and therefore filed the issues in the correct spot.

[hohwille]

For the record: There are several very picky checkstyle rules active in our config that should also be discussed:

• JavadocTagContinuationIndentationCheck - is that really something to verify and address on the level of SonarQube. Eclipse might format this different from IntelliJ and in the end it does not matter at all for real quality so discussing about things like this is pure waste.
• CyclomaticComplexityCheck with a max of 10 might also be kind of dangerous. While in general this is not such a bad idea, the metric is defined in a very stupid way and some case statements or if cascades can easily cause a complexity higher than 10. If this results in developers splitting the code that belongs perfectly together into separate methods just at some random point only for the sane of the rule the quality will not increase but decrease.

There might be more in this regard. I can do some testing on this and file a new issue for it if applicable...

[hohwille]

I assume that this issue is fixed and can be closed. However, my tests are currently blocked by #141.

[hohwille]

Another interesting fact is that the file that I initially created came from here and is still present: https://github.com/devonfw/ide-settings/blob/master/sonarqube/profiles/Devon-Java.xml

It has correct indentation configured and lots of other differences. So something went wrong when PR #56 was implemented.