devongovett / atom-jade

Jade TextMate bundle converted for Atom
51 stars 26 forks source link

Separate HTML tags from classes/ids #1

Closed orbiteleven closed 10 years ago

orbiteleven commented 10 years ago

The TextMate and SublimeText jade packages have a different color for HTML tags vs CSS classes and ID's. That'd be nice to have.

devongovett commented 10 years ago

Interesting. This was ported from the TextMate bundle using the atom converter tool so it seems like it should do that. I used this textmate bundle. Is that the one you use?

orbiteleven commented 10 years ago

Ok... so TBH I've been using SublimeText 3 for a while and not really sure that the TextMate pack works. That's my memory, though. If it'll help I can dig up which pack it is. I installed it through Package Manager.

phaseOne commented 10 years ago

Yeah... There's a lot of problems with this package. This fork is the most up-to-date as far as jade-tmbundle goes.

devongovett commented 10 years ago

If either of you want to take over maintaining this package, I would be open to that. I don't have a lot of time to put into it at the moment.

adrianlee44 commented 10 years ago

Directly converting the fork mentioned by @phaseOne using Atom converter tool seems to break Atom completely. I'm currently trying to port one pattern at a time and fix patterns along the way.

phaseOne commented 10 years ago

@adrianlee44 Happen to get anywhere with your efforts?

adrianlee44 commented 10 years ago

@phaseOne, I haven't touched it for a month but last time was I was porting over the grammar, I ran into an Atom bug and it will crash Atom. I then proceed to remove that rule to see if it works properly. It works but the grammar seems to be different from the previous one and its syntax highlighting was different. I'll probably take a crack at it again soon.

luisfontes commented 10 years ago

Hey guys, I've just converted the davidrios package and it is working like a charm.

phaseOne commented 10 years ago

@luisfontes submit a pull request?

luisfontes commented 10 years ago

submitted

devongovett commented 10 years ago

Just published v0.2.0 with #11. Thanks @luisfontes!