Silence security audit warnings; don't publish test fixtures

devongovett / exif-reader

A small EXIF image metadata reader

MIT License

145 stars 22 forks source link

Silence security audit warnings; don't publish test fixtures #13

Closed lovell closed 4 years ago

lovell commented 4 years ago

Prevent tests and fixtures being published to npm
Upgrade mocha to latest to silence security audit warnings

lovell commented 4 years ago

@papandreou Any thoughts/comments before I merge this one too?

papandreou commented 4 years ago

@lovell, looks good to me! In general I prefer using the top level files property in package.json to control what gets included in the published package. That’s easier to maintain than blacklisting in .npmignore (which also used to be bug-ridden and have a weird relationship with .gitignore).

lovell commented 4 years ago

@papandreou I agree, that's much nicer (especially as we only have to include one extra file), I've updated this PR accordingly.