devongovett / exif-reader

A small EXIF image metadata reader
MIT License
145 stars 22 forks source link

Check for non-ascii data in ascii fields #18

Closed thomasgassmann closed 1 year ago

thomasgassmann commented 4 years ago

As suggested in the issue, if non-ascii data is detected, we return the raw buffer and the endianness instead.

This fixes #17

thomasgassmann commented 1 year ago

@lovell Is there any timeline on when we could get this merged?

lovell commented 1 year ago

Oh wow, sorry, this PR completely passed me by. Would you be able to rebase, then I can merge and publish, thank you.

thomasgassmann commented 1 year ago

@lovell I've rebased it.

lovell commented 1 year ago

Thank you very much Thomas. I plan to publish a new version after https://github.com/devongovett/exif-reader/pull/24 is merged.

thomasgassmann commented 1 year ago

Thanks!

lovell commented 1 year ago

v1.2.0 now available, thanks again for your help.