search

devongovett / exif-reader

A small EXIF image metadata reader
MIT License
145 stars 22 forks source link

Add fuzz testing setup #6

Closed papandreou closed 4 years ago

papandreou commented 8 years ago

This is how I found out what to fix in https://github.com/devongovett/exif-reader/pull/5

This PR will be marked as failing, but when combined with the fixes in https://github.com/devongovett/exif-reader/pull/5 it will succeed.

lovell commented 4 years ago

@papandreou Thank you for these tests. I tried running them locally after merging #5 but see a few failures that all look a bit like:

  expected Buffer([0x45, 0x78, 0x69, 0x66, 0x00, 0x00, 0x4D, 0x4D, 0x00, 0x2A, 0x00, 0x00, 0x00, 0x08, 0x00, 0x0B /* 8142 more */ ]) to either parse or throw documented error
    Threw unexpected error: TypeError [ERR_INVALID_ARG_TYPE]: The "offset" argument must be of type number. Received type string
        at validateNumber (internal/validators.js:130:11)

I realise this PR was opened a while ago, so no worries if you're unable to do so now, but if you do have the time please can you see if there's anything obvious that can be updated/fixed so we can merge this useful feature.

papandreou commented 4 years ago

@lovell, got it back into shape now and found another bug (#14) :hugs:

lovell commented 4 years ago

Brilliant, thank you Andreas.