search

devongovett / reader

An API Compatible Replacement for Google Reader
355 stars 26 forks source link

Fixing the acceptance tests for Subscriptions #15

Closed julien51 closed 8 years ago

julien51 commented 11 years ago

They pass for me too on Google Reader now :)

devongovett commented 11 years ago

Ok, this is good... Perhaps it should be an option in the settings.json file? It is good to check that other feeds aren't being subscribed to or tags being created that shouldn't be there though, which is why I made a separate test account for that purpose. I was going to make the test suite unsubscribe and reset all of the data it messed with when it's done running to reset the state, but you wouldn't want to do that if working with an account that is being used for other purposes. Let me know what you think is best.

julien51 commented 11 years ago

To be honest, I don't have a good answer for you. I'd say it's not important either way as google reader will soon be gone anyway. I wanted to make sure I had a test suite running correctly so I know where to fix things on my end vs. in the tests.

The first issue that I have is that you check the size of the token and that you require it to be 24 chars. As it is the case for Google Reader, how much does it really matter? 3rd party apps probably don't use that information (which does not seem to be specified), but then, maybe some do?

Our API currently generates token that are 49 characters long :/

Julien

devongovett commented 11 years ago

I'm not sure either. I tried to make my clone as close to the official one as I could. Not sure how many apps depend on that, but some could have local databases to store tokens that only hold 24 chars... I think we'll have to get feedback from devs on that one. I can't find anywhere that this was documented, I just copied what the Google API was giving back. So... up to you whether you follow it or not. The real test will be when we are able to test our API clones with actual clients, something which I hope to do at least via proxies very soon.