trimLeft and trimRight stripped `s` characters, not whitespace

devongovett / slang

A collection of utility functions for working with strings in JavaScript in the browser or Node

MIT License

169 stars 14 forks source link

trimLeft and trimRight stripped `s` characters, not whitespace #2

Closed michaelficarra closed 13 years ago

devongovett commented 13 years ago

Oops. I can't believe my typos sometimes! Thanks!

michaelficarra commented 13 years ago

Yeah, you would think the unit tests would have found that one. Maybe you should look into those as well.

edit: I had a quick look at the tests and they look fine. Maybe they were already failing and nobody took the time to run them.

devongovett commented 13 years ago

Ah, it's because I run the tests on Node which has a native implementation of those methods... Perhaps I should figure out how to run them in the browser has well. :)