search

devopera / puppet-docsf

ConfigServer-Firewall puppet config
Other
3 stars 4 forks source link

Check if docsf is installed fails on systemd-based distributions #5

Closed e-it closed 6 years ago

e-it commented 8 years ago

Hello,

I added

    if (File.exist? "/usr/lib/systemd/system/csf.service") || (File.exist? "/etc/init.d/csf")

to lib/facter/configserver_firewall.rb as a workaround.

cleverlight commented 8 years ago

That's sensible. If that's the only change that's required to add support, let me know and I'll merge that code in.

Cheers, Alex

On 27 July 2016 at 08:58, e-it notifications@github.com wrote:

Hello,

I added

if (File.exist? "/usr/lib/systemd/system/csf.service") || (File.exist? "/etc/init.d/csf")

to lib/facter/configserver_firewall.rb as a workaround.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/devopera/puppet-docsf/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/ABx_qNZq0R5Dk4wzhf2CdalMmh25GpTNks5qZw-cgaJpZM4JV7nC .

e-it commented 8 years ago

It was the only thing I had to change to get it working with systemd-based servers. Before the script always downloaded the csf which lead to errors sometimes if the package could not be fetched and the tar was corrupted.

cleverlight commented 8 years ago

I've updated the code, tested on RHEL7 (for systemd), committed to master and pushed. Thanks for the feedback.

On 27 July 2016 at 13:07, e-it notifications@github.com wrote:

It was the only thing I had to change to get it working with systemd-based servers. Before the script always downloaded the csf which lead to errors sometimes if the package could not be fetched and the tar was corrupted.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/devopera/puppet-docsf/issues/5#issuecomment-235565940, or mute the thread https://github.com/notifications/unsubscribe-auth/ABx_qF0FtZNSwMhlRrLzXrMLdlIgVZlcks5qZ0nngaJpZM4JV7nC .