devops-coop / ansible-haproxy

Installs and configure HAProxy
Apache License 2.0
96 stars 97 forks source link

Add features and smartos support #1

Closed rafecolton closed 10 years ago

rafecolton commented 10 years ago

This pull request adds the following things:

NOTE: there was some whitespace change, so this may be more readable with ?w=1

rafecolton commented 10 years ago

Also ping @meatballhat @jszwedko @alexschlessinger for code review

PierrePaul commented 10 years ago

Very awesome work! I will try to get this testing this weekend on both smartos and ubuntu.

Thanks again!

rafecolton commented 10 years ago

FWIW we are using this to set up production SmartOS hosts

rafecolton commented 10 years ago

@PierrePaul bump - any word on this?

PierrePaul commented 10 years ago

Sorry, real life kicked in. I'm on vacation now, should be able to review it at the start of next week. Sorry for the long wait.

rafecolton commented 10 years ago

Ok, thanks for following up :smile:

PierrePaul commented 10 years ago

Everything seems good. This is a major contribution, want me to add your name and your company in the README and the meta/main.yml ?

I was only able to test it under ubuntu (14.04). Some options (like compression) are only possible with the 1.5 version, so I am thinking of adding a note about it in the README file.

rafecolton commented 10 years ago

Sure :smile: works for me

PierrePaul commented 10 years ago

Done ! Commit : af0a8b17c9191fae47d68005582f9200240884ce Sorry it took so much time and thanks again :)

rafecolton commented 10 years ago

Great, thanks!