Closed rafecolton closed 10 years ago
Also ping @meatballhat @jszwedko @alexschlessinger for code review
Very awesome work! I will try to get this testing this weekend on both smartos and ubuntu.
Thanks again!
FWIW we are using this to set up production SmartOS hosts
@PierrePaul bump - any word on this?
Sorry, real life kicked in. I'm on vacation now, should be able to review it at the start of next week. Sorry for the long wait.
Ok, thanks for following up :smile:
Everything seems good. This is a major contribution, want me to add your name and your company in the README and the meta/main.yml ?
I was only able to test it under ubuntu (14.04). Some options (like compression) are only possible with the 1.5 version, so I am thinking of adding a note about it in the README file.
Sure :smile: works for me
Done ! Commit : af0a8b17c9191fae47d68005582f9200240884ce Sorry it took so much time and thanks again :)
Great, thanks!
This pull request adds the following things:
socat
for the socket apihaproxy
after rewriting the config (note that a change to the#{{ ansible_managed }}
comment does not trigger a restart)listen
sections (in addition to separatefrontend
andbackend
sections)false
(without breaking default vars already set in the role)NOTE: there was some whitespace change, so this may be more readable with
?w=1