search

devops-coop / ansible-haproxy

Installs and configure HAProxy
Apache License 2.0
96 stars 97 forks source link

change order of some rules to avoid warnings #106

Closed fw8 closed 6 years ago

fw8 commented 6 years ago

place tcp-request, http-request and http-response rules in front of reqxxx and rspxxx rules to avoid warnings like:

[WARNING] 327/172846 (4677) : parsing [/etc/haproxy/haproxy.cfg:110] : a 'http-request' rule placed after a 'reqadd' rule will still be processed before.

benwebber commented 6 years ago

Thanks again for your contribution, Florian. Unfortunately we cannot accept this PR because big changes are coming to this role (#107)!

As you are well aware, the current role is not very flexible and requires frequent changes to adapt to users' requirements.

The next major version of this role introduces a flexible configuration syntax that obsoletes these trivial changes. You can read a description of the new syntax here:

https://github.com/devops-coop/ansible-haproxy/blob/3ef2eb9f3d22ff27a1043c689b3819c87ab44ffa/README.md

Cheers!