devops-coop / ansible-haproxy

Installs and configure HAProxy
Apache License 2.0
96 stars 97 forks source link

Improve [global] ssl configuration. Provide default ssl configuration for 'A' rating in ssllabs checks #85

Closed reminec closed 7 years ago

reminec commented 7 years ago

Hello !

I was using this role and my fix before the change of maintainers. I decided to switch on the original fork with new maintainers.

In this PR, 3 commits : 2 for closing issues #83 and #84 1 for ability to have a good rating on ssllabs checkings. Maybe your prefer to switch this configuration in the vars/main.yml example ?

Let me know ;)

benwebber commented 7 years ago

Thanks for your contribution, Rémi. Would you mind opening a separate PR with the indentation/macro changes?

Something like this would work:

# Create a separate branch containing the indentation commit.
git checkout -b fix/indentation
git push -u origin fix/indentation
# Remove the indentation commit from `master` and force push.
git checkout master
git reset --hard HEAD~
git push -f
reminec commented 7 years ago

Done ;)

benwebber commented 7 years ago

Thanks! I will try and get to these this week.