Allow us to set any key => value pair in frontend.

devops-coop / ansible-haproxy

Installs and configure HAProxy

Apache License 2.0

96 stars 97 forks source link

Allow us to set any key => value pair in frontend. #9

Closed scottrobertson closed 10 years ago

rafecolton commented 10 years ago

This seems reasonable, although it is not quite in the spirit of the rest of the template which declares all of the keys explicitly. Would love to know @PierrePaul's opinion on this.

Also, have you confirmed that the template renders correctly given the spacing above?

PierrePaul commented 10 years ago

I also agree with @rafecolton.

@scottrobertson, if you need a particuliar option, do you mind creating a key for each option?

scottrobertson commented 10 years ago

I created my own fork and merged all these PR's as I needed them, it all seems to work fine :) shall switch back to this one once/if they are all merged. I would do some tests too though as i may have missed something.

scottrobertson commented 10 years ago

And yeah, I wasn't a fan of doing this. I just wasn't a fan of spamming you will lots of PR's in the future if needed. I am going to close this, not a fan of it after thinking about it. Reopen if you would still like it :)