search

devops-coop / ansible-minecraft

Ansible role for provisioning a vanilla Minecraft server
https://galaxy.ansible.com/devops-coop/minecraft/
Apache License 2.0
57 stars 38 forks source link

Fix acl user group #3

Closed markrcote closed 8 years ago

markrcote commented 8 years ago

Hi, I've got a few little fix-ups here. I also added Emacs temp files (*~) to the .gitignore; hope that's okay.

Thanks for writing this!

Btw I had some issues with the tests; couldn't get jessie64 running at all, but it seemed to be a Vagrant problem (something to do with ssh known hosts). trusty64 worked, but only on the second run (race condition perhaps). I may dig into this later.

benwebber commented 8 years ago

Thanks for fixing the ACL module. I figure it worked in my tests because by chance my user's uid and gid matched.

I also added Emacs temp files (*~) to the .gitignore; hope that's okay.

If it helps you and other Emacs users, it's fine my me.

For what it's worth, I use a global .gitignore for this purpose.

I had some issues with the tests; couldn't get jessie64 running at all, but it seemed to be a Vagrant problem (something to do with ssh known hosts).

I have run into similar issues.

At some point during my tests, localhost:2222 was added to my known hosts. I'm not sure if that came from Vagrant, Ansible, or SSHing to the Vagrant box manually.

Since the Vagrant box host key changes between boxes, this causes host key mismatch errors.

If you can track down the issue I'd be happy to merge the fixes.

Edit: Inserted words in bold.