devops-customers-squad / customers

This repository contains the implementation of the customers RESTful Flask service to be used by the eCommerce site.

Apache License 2.0

0 stars 2 forks source link

Dome delete several addresses #216

Closed domejiraphon closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #216 (4678507) into main (0e8eef2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files           4        4           
  Lines         530      530           
=======================================
  Hits          525      525           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e8eef2...4678507. Read the comment docs.

ryanjcohen commented 2 years ago

I'm not able to run the behave tests with the change. Looks like all scenarios are followed by "Assertion Failed: Expected 404 to equal 200"

domejiraphon commented 2 years ago

Solved the 404 error.

Bobby-Zien commented 2 years ago

Hi dome, I'm thinking that maybe we can manually add addresses for the list customer's addresses BDD testing. Instead of adding a second addresses to the background. Sorry it was my misunderstanding of the code. My initail thought was that we need to have background for the addresses, but right now I think it's not necessary. Feel free work on the list customer's addresses issue, or I'd like to work on that :)

I have updated the AC for list customer's addresses, you can use that scenario for the BDD test

domejiraphon commented 2 years ago

Okay, I can work on the new issue.