search

devops-customers-squad / customers

This repository contains the implementation of the customers RESTful Flask service to be used by the eCommerce site.
Apache License 2.0
0 stars 2 forks source link

Issue #217 - Fix setting of BASE_URL in environment.py #218

Closed ryanjcohen closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #218 (a4ddd46) into main (9a898fa) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files           4        4           
  Lines         530      530           
=======================================
  Hits          525      525           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a898fa...a4ddd46. Read the comment docs.

ryanjcohen commented 2 years ago

@YongchangLiu98 the previous change to BASE_URL in environment.py caused our BDD tests to fail locally. We need to conditionally set BASE_URL based on whether we're in the cloud, so I've made this change. I've added a variable to the configuration of the integration stage in our CI/CD pipeline