devops-ia / helm-cruise-control

Helm chart for Cruise Control
https://devops-ia.github.io/helm-cruise-control/
MIT License
2 stars 1 forks source link

Invalid Probes #12

Closed Fissium closed 1 day ago

Fissium commented 1 day ago

Describe the bug a clear and concise description of what the bug is.

liveness, rediness and startup probes are invalid:

livenessProbe:
  enabled: true
  failureThreshold: 3
  initialDelaySeconds: 180
  periodSeconds: 10
  successThreshold: 1
  timeoutSeconds: 5

What's your helm version?

3.16.3

What's your kubectl version?

1.31.2

Chart version

1.1.4

Explain bug

The probes configuration includes an invalid enabled field, which is not recognized in Kubernetes. This causes deployment errors.

What you expected to happen?

No response

How to reproduce it?

No response

Enter the changed values of values.yaml?

No response

Enter the command that you execute when chart failing/misfunctioning

I use argocd

More info

No response

ialejandro commented 1 day ago

On the next helm release, you can modify your custom probes. Idk if by default / works or not. You can disable or modify your custom probes (path, port, etc)