Closed TomOConnor95 closed 2 years ago
Hello.
Thank you for taking an interest in my action and improving it.
I've just added pr_number
to outputs in v0.5.2
.
Amazing! Thanks so much! 🎉🎉🎉
On 3 Nov 2022, at 10:04, Krzysztof Szyper @.***> wrote:
Hello. Thank you for taking an interest in my action and improving it. I've just added pr_number to outputs in v0.5.2.
— Reply to this email directly, view it on GitHubhttps://github.com/devops-infra/action-pull-request/issues/104#issuecomment-1301810732, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGMAILKVVZGNUIMHYDAU5H3WGN5ZVANCNFSM6AAAAAARTGC7NI. You are receiving this because you authored the thread.Message ID: @.***>
Hello, I am using your action to create a pr, (it was successfully created) however, it seems like the pr_number is empty
can you please tell me if I am doing something wrong?
Hello @whiteKhoukha . Sorry I missed your post.
This has been fixed in devops-infra/action-pull-request@v0.5.5
:memo: Brief description
description of what the issue is.
The action only has an output of
url
(pull request url) If you want to perform additional additional actions after this action it is very helpful to know the number of the pull request, not the full URL. (For my use-case I want to run peter-evans/enable-pull-request-automerge@v2 afterwards)description of what is expected.
An additional output to be provided, with name
pull-request-number
description of any alternative solutions or other features.
For now I am taking the pull request url, and parsing the pull request number from it. Not a dealbreaker, but a bit fiddly to do. Plus if the url scheme for github pull requests ever changes, I'd have to adjust my logic
Here's what I'm doing to extract the PR number
:warning: Checklist
Check CONTRIBUTING.md and CODE_OF_CONDUCT.md for more information