search

devops-israel / aws-inventory

AWS Inventory in a single HTML file using JS AWS-SDK & Bootstrap
MIT License
388 stars 121 forks source link

Fixing ECS: Moving to listClusters, ignoring headers (there are none … #11

Closed omerxx closed 6 years ago

omerxx commented 6 years ago

…in the list response)

kesor commented 6 years ago

Can also choose any title via JMESPath.

On Tue, 6 Feb 2018 at 19:27 Omer Hamerman notifications@github.com wrote:

@omerxx commented on this pull request.

In index.html https://github.com/devops-israel/aws-inventory/pull/11#discussion_r166380186 :

@@ -998,21 +998,37 @@ function createTableHead(headings) { const tr = $('') tr.append($('#'))

  • for (let h=0; h<headings.length; h++) {
  • tr.append($(<th>${headings[h]}</th>))
  • if (headings.length == 0) {

Basically, I can check if the head is empty, just wanted to put some meaningful title. I'll change it.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/devops-israel/aws-inventory/pull/11#discussion_r166380186, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAbkNoXh0nkppbUPV1OEDd19W16tfkxks5tSItogaJpZM4R65R4 .

omerxx commented 6 years ago

Done