search

devops-kung-fu / bomber

Scans Software Bill of Materials (SBOMs) for security vulnerabilities
https://devops-kung-fu.github.io/bomber/
Mozilla Public License 2.0
518 stars 45 forks source link

feat: add support for alternative Snyk API URLs #268

Closed mcombuechen closed 1 week ago

mcombuechen commented 2 weeks ago

Hey @djschleen

we've had a few customers who requested we bring in a new feature where you can specify a Snyk API other than https://api.snyk.io. This is especially attractive to our customer base in the EU and Australia (but not exclusively) where there are local APIs, e.g. https://api.eu.snyk.io.

Let me know if you think this is a good addition. Cheers!

mcombuechen commented 2 weeks ago

Btw I noticed that most tests from the snyk provider package were commented out, is this intentional?

mcombuechen commented 2 weeks ago

Closes #215.

djschleen commented 2 weeks ago

Heya! I was working on getting the configurable URL in place so a lot of the tests were breaking. I'll take a look at this PR and merge it in. Thanks!

mcombuechen commented 2 weeks ago

@djschleen Cool, thanks for the reply and sorry if this might conflict with your changes. FWIW, SNYK_API is an env var that we also use for the Snyk CLI, so chances are that customers would expect this specific key. Just an FYI 😄