search

devops-rob / vault-plugin-boundary-secrets-engine

A Vault secrets engine that generates dynamic Boundary accounts
Apache License 2.0
12 stars 1 forks source link

Darwin binaries don't work on Mac #12

Open seanamos opened 11 months ago

seanamos commented 11 months ago

Reproduction

mkdir -p ~/tmp/boundary
cd ~/tmp/boundary

curl -L -o boundary.zip https://github.com/devops-rob/vault-plugin-boundary-secrets-engine/releases/download/v1.0.2/vault-plugin-boundary-secrets-engine_v1.0.2_darwin_arm64.zip

unzip boundary.zip -d .

./vault-plugin-boundary-secrets-engine_v1.0.2
zsh: exec format error: ./vault-plugin-boundary-secrets-engine_v1.0.2

I suspect this is caused by a small error in the Makefile:

zip:
        ...
    zip -j ./bin/vault-plugin-$(name)-$(plugin_type)_v$(version)_darwin_arm64.zip ./bin/linux_arm64/vault-plugin-$(name)-$(plugin_type)_v$(version)
    zip -j ./bin/vault-plugin-$(name)-$(plugin_type)_v$(version)_darwin_amd64.zip ./bin/linux_arm64/vault-plugin-$(name)-$(plugin_type)_v$(version)
        ...

Note the source folder ./bin/linux_arm64 used to produce both darwin zips.