search

devops-works / binenv

One binary to rule them all. Manage all those pesky binaries (kubectl, helm, terraform, ...) easily.
MIT License
372 stars 44 forks source link

fix: fetch url from eksctl is prefixed by a 'v' #161

Closed angrox closed 2 years ago

angrox commented 3 years ago

The fetch url from eksctl changed: The version in the url is prefixed by the letter 'v'

patsevanton commented 2 years ago

before PR

2021-10-13T09:36:18+06:00 WRN version for "eksctl" not specified; using "0.69.0"
2021-10-13T09:36:19+06:00 ERR unable to install "eksctl" (0.69.0) error="unable to download binary at https://github.com/weaveworks/eksctl/releases/download/0.69.0/eksctl_Linux_amd64.tar.gz: 404 Not Found"

after PR

2021-10-13T09:37:02+06:00 WRN version for "eksctl" not specified; using "0.69.0"
fetching eksctl version 0.69.0 100% |█████████████████████████████████████████████████████████████████████████████████████████████████████| (19/19 MB, 8.884 MB/s)        
2021-10-13T09:37:05+06:00 INF "eksctl" (0.69.0) installed
leucos commented 2 years ago

Nice catch @angrox ! thanks for the test @patsevanton :+1: