Add List date create of cache.json file to Action

devops-works / binenv

One binary to rule them all. Manage all those pesky binaries (kubectl, helm, terraform, ...) easily.

MIT License

376 stars 44 forks source link

Add List date create of cache.json file to Action #166

Closed patsevanton closed 3 years ago

patsevanton commented 3 years ago

I have idea how fix https://github.com/devops-works/binenv/issues/162 https://github.com/devops-works/binenv/issues/159 https://github.com/devops-works/binenv/issues/157 https://github.com/devops-works/binenv/issues/156

1) check cache.json of [] 2) run update for app with []

patsevanton commented 3 years ago

But need first know where store update -f

leucos commented 3 years ago

Thanks @patsevanton for the suggestion ! I finally fixed this in todays commits.

Basically, if the versions slice returned by the fetcher goroutine has zero length, it is simply ignored and the entry in the cache is not updated. I also lowered the concurrency which seems to be the culprit in the action (although it works well locally with a GH token, go figure ¯_(ツ)_/¯).