devops-works / binenv

One binary to rule them all. Manage all those pesky binaries (kubectl, helm, terraform, ...) easily.
MIT License
366 stars 44 forks source link

kubectl-krew install broken #217

Closed jgournet closed 1 year ago

jgournet commented 1 year ago

Hi there, Any chance you could fix kubectl-krew install ?

binenv update
2022-10-28T09:38:39+11:00 INF retrieving distribution cache from https://raw.githubusercontent.com/devops-works/binenv/develop/distributions/cache.json
2022-10-28T09:38:39+11:00 INF fetched updates for 275 distributions

binenv install kubectl-krew
2022-10-28T09:38:41+11:00 WRN version for "kubectl-krew" not specified; using "0.4.3"
2022-10-28T09:38:41+11:00 ERR unable to install "kubectl-krew" (0.4.3) error="unable to download binary at https://github.com/kubernetes-sigs/krew/releases/download/v0.4.3/krew.tar.gz: 404 Not Found"

Note: looks like they changed their artifact file names: 0.4.2 fails, while 0.4.1 works:

binenv install kubectl-krew 0.4.2
2022-10-28T09:39:33+11:00 ERR unable to install "kubectl-krew" (0.4.2) error="unable to download binary at https://github.com/kubernetes-sigs/krew/releases/download/v0.4.2/krew.tar.gz: 404 Not Found"

binenv install kubectl-krew 0.4.1
fetching kubectl-krew version 0.4.1 100%      
2022-10-28T09:42:00+11:00 INF "kubectl-krew" (0.4.1) installed

thanks !

cleming commented 1 year ago

Hi @jgournet

It's works fine, here. Have you updated the cache?

❯ binenv update -f kubectl-krew
updating distributions 100% |████| (1/1, 15079 it/s)

❯ binenv install kubectl-krew
2022-10-29T12:17:56+02:00 WRN version for "kubectl-krew" not specified; using "0.4.3"
fetching kubectl-krew version 0.4.3 100% |████| 3.9/3.9 MB, 488.304 kB/s)        
2022-10-29T12:18:06+02:00 INF "kubectl-krew" (0.4.3) installed
jgournet commented 1 year ago

@Cleming : what kind of dark magic is this ? :)

> binenv update -f kubectl-krew
updating distributions 100% 

> binenv install kubectl-krew
2022-10-31T07:28:54+11:00 WRN version for "kubectl-krew" not specified; using "0.4.3"
2022-10-31T07:28:55+11:00 ERR unable to install "kubectl-krew" (0.4.3) error="unable to download binary at https://github.com/kubernetes-sigs/krew/releases/download/v0.4.3/krew.tar.gz: 404 Not Found"

knowing it works for you, I'll check on my side. Thanks

(closing in doubt - I'll re-open or update if needed)

cleming commented 1 year ago

Hi @jgournet i think you have an old version of the distribution list (before this commit https://github.com/devops-works/binenv/commit/6292039582596e45c10777dc92e7b1c0bc347113 )

So, i think that binenv update -d will fix your issue :)

jgournet commented 1 year ago

binenv update -d did the trick ! thanks