devopsacademyau / 2020-feb-project1-group2

Creative Commons Attribution Share Alike 4.0 International
0 stars 2 forks source link

Terraform Folder Restructure #31

Closed starkmatt closed 4 years ago

starkmatt commented 4 years ago

Terraform Code

As per Kiko's recommendation I've taken a clone of the Repo and restructured the folder so all the files are in one folder.

VPC

RDS Aurora

ECS

I also need to split the ECS.tf File apart as there are alot of mixed resources in there, I plan to create;

And finally an ECS File.

drii-cavalcanti commented 4 years ago

Finally, could you create a repository structure?

something like:

Terraform: ├── README.md ├── variables.tf ├── main.tf ├── outputs.tf ├── modules │ ├── VPC │ │ ├── README.md │ │ ├── variables.tf │ │ ├── vpc.tf │ │ ├── outputs.tf │ ├── ECS │ │ ├── README.md │ │ ├── variables.tf │ │ ├── ecs.tf │ │ ├── outputs.tf

faria-marcio commented 4 years ago

I could run the terraform successfully, but the terraform destroy return the following error:

In the exercise c04-rds02 we had to delete a database, so it might be worth have a look at it.

Apart from that, the terraform code LGTM. But I am wondering if this PR isn't duplicated as the VPC terraform code was already merged to master in a different PR (I guess), and there are the tasks #14 RDS - DB and #8 ECS Cluster to delivery these terraform's code?

starkmatt commented 4 years ago

I could run the terraform successfully, but the terraform destroy return the following error:

  • Error: RDS Cluster FinalSnapshotIdentifier is required when a final snapshot is required

In the exercise c04-rds02 we had to delete a database, so it might be worth have a look at it.

Apart from that, the terraform code LGTM. But I am wondering if this PR isn't duplicated as the VPC terraform code was already merged to master in a different PR (I guess), and there are the tasks #14 RDS - DB and #8 ECS Cluster to delivery these terraform's code?

Hey Marcio, I left a note here regarding the FinalSnapshotIdentifier

https://github.com/devopsacademyau/2020-feb-project1-group2/pull/15

PS You may run into some issues when running terraform destroy after. If this is the case, you'll need to edit your tf.state file and set the following argument to true skip_final_snapshot = true

Yes the code is duplicated, we decided on putting the code into all one folder so it's easier to add and contribute to the source code collectively 😄