search

devopsdays / devopsdays-cli

Maintenance application for devopsdays.org website
MIT License
1 stars 1 forks source link

[DRAFT] Move to go modules, correct test issues, other fixes. #133

Closed chriscoffee closed 4 years ago

chriscoffee commented 5 years ago

I'm marking this as work in progress. Hope you don't mind whilst I get the app working on 1.13 correctly.

I'll write a better description when I'm not super tired from Ghent 🇧🇪

This change is Reviewable

welcome[bot] commented 5 years ago

:heart: Thanks for opening this pull request! :heart: Please check out our contributing guidelines.

mattstratton commented 5 years ago

Thanks, @chriscoffee ! On this repo we don't mind draft PR's, etc :)

mattstratton commented 5 years ago

One thing that would be nice - I noticed you are working on the dockerfile, which I think is connected to an existing issue (#109). If you add closing keywords to your initial description of the PR, it will automatically close that issue when this PR is merged. Not sure if this PR fixes any other issues, but if so, maybe add them too?

sourcelevel-bot[bot] commented 5 years ago

Hello, @chriscoffee! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

mattstratton commented 5 years ago

Sorry for all the nagging bots that are critiquing your code, @chriscoffee :)

mattstratton commented 4 years ago

@chriscoffee I would like to get back to working on this project, but I've been holding off on anything until this PR is merged. If you aren't planning on doing any more with it, can you document the current state of this, and we can merge it (even though it might have some breaks) and I can pick up from there?

chriscoffee commented 4 years ago

Hey @mattstratton. Sorry about this! 😞 I took a break from basically everything...

I think with this ticket it's best I split it down to its individual parts then it's not blocking:

  1. The fixes to get modules and up to date go versioning. (This will be relatively easy to pull out, I'll also update stuff again whilst I'm there)
  2. Moving some of the deployment stuff out (don't think there's much left here just some discussion around keying)

I'll pull off 1 ASAP (probably try get it done when I get home from work) to get this going then the other can just work on.

Again sorry for the delay!

mattstratton commented 4 years ago

Sounds good! I've been seeing a few issues pop up in devopsdays/devopsdays-web that are related to the bash scripts which would be solved with devopsdays-cli so I was going to get going on this again :)

chriscoffee commented 4 years ago

Closing this PR as I'm opening the above on another branch.

Cheers