search

devopsdays / devopsdays-theme

⛔️DEPRECATED - Hugo theme for devopsdays.org
Other
5 stars 12 forks source link

single-day events displaying incorrectly on welcome page #663

Closed bridgetkromhout closed 5 years ago

bridgetkromhout commented 5 years ago

As reported by @robscott in https://github.com/devopsdays/devopsdays-web/issues/5565, single-day events are displaying incorrectly. I have a correction pending for this regression.

bridgetkromhout commented 5 years ago

Part of the build timed out, but you can see it in action in the branch deploy that didn't time out: https://fix-dates-welcome-page--devopsdays-theme.netlify.com/events/2018-paris/welcome/

screen shot 2018-10-06 at 6 17 24 pm

contrasted with what's live in production before the fix is available: https://www.devopsdays.org/events/2018-paris/welcome/

screen shot 2018-10-06 at 6 17 04 pm
Devopsdays Paris 2018
devopsdays Paris 2018
Devopsdays Paris 2018
devopsdays Paris 2018
bridgetkromhout commented 5 years ago

Likely of interest to @robscott, who reported this issue. The part controlled by the theme will be updated when this is reviewed, merged, and deployed by @mattstratton.

Please note that for your one-day event you'll probably want to edit https://github.com/devopsdays/devopsdays-web/blame/master/content/events/2018-chattanooga/welcome.md#L12-L17 to say "Date" and only use one of event_start or event_end - that's controlled by you, not by the theme, but is probably what you want to do there.

GitHub
devopsdays/devopsdays-web
This is the website for devopsdays.org. Contribute to devopsdays/devopsdays-web development by creating an account on GitHub.
mattstratton commented 5 years ago

Huh. This used to work.

bridgetkromhout commented 5 years ago

Huh. This used to work.

Right. I think this is a regression caused by the datetime cleanup work. Is there anything else you'd like done here? I'd like to get this fix into production.