devopsdays / devopsdays-web

This is the website for devopsdays
https://www.devopsdays.org
Other
173 stars 664 forks source link

fix embedding of PDFs on talk page #6542

Open mattstratton opened 6 years ago

mattstratton commented 6 years ago

I'm not 100% sure if this ever worked (I didn't write the code for this) but on the shown example, the PDF viewer bumps into the sponsor row, and it is not usable.

image

bridgetkromhout commented 6 years ago

I see this happening on a Minneapolis 2017 talk and I'm pretty sure it was not happening when I updated the site at the time: https://www.devopsdays.org/events/2017-minneapolis/program/kristen-womack/

Logs & Alerts, Not Just for Ops
Let’s look at how to use system data to uncover the deeper story of your product, to understand what users want without asking them and without guessing. Focusing on the ‘learn’ aspect of the build-measure-learn development cycle, let’s make better use of system logs and other data to inform what we build. Think of it as bringing a deeper connection between roadmaps and a DevOps culture.
bridgetkromhout commented 6 years ago

Hmm, I checked with $ git checkout 7086b38072501e49d3a83b9ec8c5280ee53c5b91 and apparently it was happening at the time, and I either didn't notice or didn't prioritize it.

bridgetkromhout commented 5 years ago

This is fixed in https://github.com/devopsdays/devopsdays-web/pull/8076 for cases of a simple-to-embed PDF. We have a corner case, it appears, if the PDF is in a github repo - github appears to block such an embed (see https://github.com/github/markup#github-markup).

bridgetkromhout commented 5 years ago

test case: content/events/2018-chicago/program/quintessence-anx.md

-slides = "https://github.com/quintessence/presentations/blob/master/sensory-friendly-monitoring/sensory-friendly-monitoring.pdf" +pdf = "https://github.com/quintessence/presentations/blob/82dab688031a5f6c338b15ca5b2aa9efa26febf3/sensory-friendly-monitoring/sensory-friendly-monitoring.pdf"

mattstratton commented 4 years ago

If github blocks embedding, I don’t see how we can code around it. This seems like a documentation update.