search

devopsdays / devopsdays-web

This is the website for devopsdays
https://www.devopsdays.org
Other
176 stars 665 forks source link

Multiline speaker bios and talk abstracts require special handling #8686

Open electrofelix opened 5 years ago

electrofelix commented 5 years ago

When adding a speaker bio or talk abstract using the utilities/add_speakers.sh script, I find that frequently it breaks and adds unexpected content if I haven't carefully prepared the text going in to correct escape any quotes in order to preserve newlines, or remove any newlines present.

Consequently I often input nothing at this point and then need to open the generated files to insert the details directly to avoid problems.

An alternative would be to support multiline input.

In order to simplify adding speakers to the event for 2019, I made some local modifications that might be of interest in general, or perhaps a place to start a discussion on how to do this in the future. This was based on https://unix.stackexchange.com/a/339725/166306

see https://github.com/devopsdays/devopsdays-web/compare/master...electrofelix:multiline-bios-and-abstracts

bridgetkromhout commented 5 years ago

Thank you! This will be great as an enhancement of my exceptionally janky bash. :) I took a quick look and had some errors locally myself (macOS Mojave) - 

add_speakers.sh: line 32: syntax error near unexpected token `&'
add_speakers.sh: line 32: `        $'\04') got_eot=1   ;&'

Please do put in a PR so we can iterate on this and get it merged as soon as it's working for our most common use case (which is Macs with no GNU utils... le sigh).

mattstratton commented 5 years ago

This doesn't solve the problem, but once we get devopsdays-cli working again, the way that speaker bios and talk abstracts work is that it pops open your editor to enter them, not directly in the terminal, and it's a lot better. No promises on when this will be released, but we probably will have the MVP working again soon, and I think the speaker bio version actually works :)