Docker Not Found ! - Githubissues

devopshobbies / boundary-vault-stack

Deploy Self-Hosted HCP Vault and Boundary using End-To-End Automation (Terraform, Ansible, Bash, and many more)

MIT License

14 stars 14 forks source link

Docker Not Found ! #9

Open Shayan-Ghani opened 3 months ago

Shayan-Ghani commented 3 months ago

Install and configure Docker on target (managed) node(s) (prepare_env role).

RoninAngle1 commented 2 months ago

I have an Ansible playbook, if you mind, I will make it public tommaro , so you can take a look at it

Shayan-Ghani commented 2 months ago

Great Idea!

RoninAngle1 commented 2 months ago

Hi again this is my repository https://github.com/RoninAngle1/ansible-docker-installation/tree/main, If you mind check it please

RoninAngle1 commented 2 months ago

If it was useful please let me have a merge request

Shayan-Ghani commented 2 months ago

Hey @RoninAngle1

Overall it looks awesome, and you'll be able to create the pr with the following improvements:

consider adding Docker-Compose version 2
Instead of prompting the user, get the values by lookup plugin from env vars to avoid interrupting the ci.
update the environment variable section of the wiki with the according to the changes made, under artifacts/wiki/index.html .

That would be great 💯👍🏽

RoninAngle1 commented 2 months ago

@Shayan-Ghani I understood what to do, but these days I'm a bit busy at work, would you mind if I complete them by end of the week

Shayan-Ghani commented 2 months ago

@RoninAngle1 No worries mate, take your time

RoninAngle1 commented 1 month ago

Hi again dear friend @Shayan-Ghani I created a poll request for this problem, sorry for being a bit late. If you mind, check it please. I considered what was expected. the pull request number is #65