devopshq / artifactory-cleanup

Extended cleanup tool for JFrog Artifactory
MIT License
125 stars 66 forks source link

Include SHA1 hash when deleting a file #144

Closed christianwaldmann closed 5 months ago

christianwaldmann commented 5 months ago

What does this PR do?

Motivation

More

christianwaldmann commented 5 months ago

Changed the default to include the sha1 hash.

I'm not sure what you mean by "export data", because the option --output is only printing the summary and not the deleted files. Therefore a hash doesn't make sense there.

allburov commented 5 months ago

Changed the default to include the sha1 hash.

Oh, sorry, I meant only that, without any additional changes.

I don't see the point of having flex format if we manually replace it later.

--output is only printing the summary and not the deleted files. Therefore a hash doesn't make sense there.

I thought it was merged already, but it's not. Never mind! https://github.com/devopshq/artifactory-cleanup/pull/136

christianwaldmann commented 5 months ago

Got it, a fixed format including the hash works fine for me too.

I updated the PR and description accordingly.

allburov commented 5 months ago

@christianwaldmann Thank you! :hugs: