devopshq / artifactory

dohq-artifactory: a Python client for Artifactory
https://devopshq.github.io/artifactory/
MIT License
270 stars 137 forks source link

add params for PermissionTarget.__init__ #368

Closed donhui closed 1 year ago

donhui commented 1 year ago

In some cases, we want to customize the parameters: includesPattern and excludesPattern. So them needed to be exposed to developers.

allburov commented 1 year ago

I think we're able to change it after initialization like this

obj = Obj()
obj.includesPattern = "what-we-need-to"
obj.create()

but it looks more "explicit" to have it in init method, thank you!

allburov commented 1 year ago

Thank you all, great job!