In #409, released in v0.9.0, we added the quote_parameters option to the deploy method and defaulted it to None (to be later converted to False) to preserve existing behavior.
We also added a warning when the value was None so that we could warn that the default value would change to True in v0.10.0.
This PR:
Changes the default to True
Removes the warning
Updates the tests to no longer check for None or a warning value, and to remove explicit setting where we aren't needing it
To be released in v0.10.0
If you would like to retain the ability to do a v0.9.x patch release, then this PR should not be merged yet, since we announced that this default would not change until v0.10.0. So once any other PR that would force that version is merged, this could be merged too.
I'm putting this up "early" so that I don't forget, and so the changes are ready when needed. Thanks!
allburov
commented
9 months ago
Follow-up to:
408
409
In #409, released in
v0.9.0, we added thequote_parametersoption to thedeploymethod and defaulted it toNone(to be later converted toFalse) to preserve existing behavior.We also added a warning when the value was
Noneso that we could warn that the default value would change toTrueinv0.10.0.This PR:
TrueNoneor a warning value, and to remove explicit setting where we aren't needing itTo be released in
v0.10.0If you would like to retain the ability to do a
v0.9.xpatch release, then this PR should not be merged yet, since we announced that this default would not change untilv0.10.0. So once any other PR that would force that version is merged, this could be merged too.I'm putting this up "early" so that I don't forget, and so the changes are ready when needed. Thanks!