search

devopshq / artifactory

dohq-artifactory: a Python client for Artifactory
https://devopshq.github.io/artifactory/
MIT License
269 stars 137 forks source link

Python 3.11 #424

Closed flichtenheld closed 11 months ago

flichtenheld commented 11 months ago

I see no way of reusing the current versions of mkdir and rmdir from pathlib. So we just need to copy them and implement on our own. The versions here are copied verbatim from Python 3.10.

Edit: Extended the patch to also fix glob. Slightly different problem. We don't need to override glob itself, but the newly added _scandir which we need to redirect to our accessor.

I implemented a basic UT for mkdir to understand how the UTs work. Note that this UT does not actually test the bug since it tests directly the ArtifactoryAccessor and not the ArtifactoryPath.

Fixes: #415 Fixes: #396

ktdreyer commented 8 months ago

Thank you for fixing these methods!

I've also found iterdir() is broken in py311, and I've fixed it in https://github.com/devopshq/artifactory/pull/433