search

devopshq / artifactory

dohq-artifactory: a Python client for Artifactory
https://devopshq.github.io/artifactory/
MIT License
273 stars 144 forks source link

version.txt: update to 1.0.0a0 #425

Closed flichtenheld closed 1 year ago

flichtenheld commented 1 year ago

setup.py only allows single digit version parts, so that means 0.9.0 needs to be follow by 1.0.0.

allburov commented 1 year ago

setup.py only allows single digit version parts

Where did the restriction come from? I think I've seen many of projects with 0.11 version as well

flichtenheld commented 1 year ago

setup.py only allows single digit version parts

Where did the restriction come from? I think I've seen many of projects with 0.11 version as well

Yeah, this is definitely specific to this project. There is this code in setup.py:

# check that version is correct (X.X.X or X.X.X.devXXX or X.X.X.alphaX), eg 0.8.0.dev0
assert re.match(
    r"^\d\.\d\.\d$|^\d\.\d\.\d\.dev\d+$|^\d\.\d\.\d\.alpha\d+$", __version__
)

I'm happy to change the patch to use 0.10.0 and change the regex to allow multiple digits.

allburov commented 1 year ago

Yes please, it'd be wonderful!