devopsspiral / KubeLibrary

Kubernetes library for Robot Framework
MIT License
138 stars 37 forks source link

Update create keyword to return created object #143

Closed aisonaku closed 2 months ago

aisonaku commented 2 months ago

I've update create keyword so that it returns the created object now. Now it is more aligned with keywords like create_namespaced_service_account or create_namespaced_cron_job.
I've modified the existing unit test for the keyword so I didn't tag it with prerelease. Please let me know if it would be better to add a new test and tag it with prerelease tag.

Before merge following needs to be applied:

devopsspiral commented 2 months ago

Hi, thanks for PR. Yes please tag it as prerelease, because if someone tries to run it with Pypi package the test will fail. Other than that please pull from master to include latest CI fixes.

aisonaku commented 2 months ago

@devopsspiral thank you for the CI fixes, merged them now and added a prerelease tag to a new testcase for dynamic client

aisonaku commented 1 month ago

@devopsspiral could you please tell what is the library release cycle? When is the next minor version with my changes is expected to be released?

devopsspiral commented 1 month ago

Hi, just released your changes on 0.8.8.