devopvoid / webrtc-java

WebRTC for desktop platforms running Java
Apache License 2.0
248 stars 60 forks source link

`jni::Exception` is thrown if a specific device or capability is chosen. #13

Closed vria closed 2 years ago

vria commented 3 years ago

Hello !

commit 1029fe intruduced a bug that prevents to choose a video capture device on the settings page.

Steps to reproduce the behavior:

  1. Go to settings page
  2. Specify any video capture device/capability
  3. Start call
  4. The application crashes

When starting a call right away everything is ok.

Details

The exception is thrown in the method PeerConnectionClient::addVideo at the line videoSource.start(); only if

videoSource.setVideoCaptureDevice(device);
videoSource.setVideoCaptureCapability(capability);

are executed. In other words it happens when device and capability are not null.

Desktop:

devopvoid commented 2 years ago

This has been fixed with 702e58c