search

devopvoid / webrtc-java

WebRTC for desktop platforms running Java
Apache License 2.0
248 stars 60 forks source link

APM module #42

Closed nanguantong closed 2 years ago

nanguantong commented 2 years ago

Hi，the apm module is incompleted, I want to use the apm aec ns, want to know how long to add this?

devopvoid commented 2 years ago

Hi, as far as I know AEC and NS are enabled by default, see here.

But yes, the AudioDeviceModule PeerConnectionFactory lacks the setting of AudioProcessing. Maybe this is of interest to you.

devopvoid commented 2 years ago

As of 0c51a2d you can provide your own AudioProcessing module to the PeerConnectionFactory.

Does that solve your issue?

nanguantong commented 2 years ago

Yeah, thanks to your advice, it's helpful, althought lack the setting of AudioProcessing, for example, near and far frame set_stream_delay_ms(delay_ms) that must be called if and only if echo processing is enabled and others params, hope to enhance it ~~~

devopvoid commented 2 years ago

What you mean, I guess, is echo cancellation, for which set_stream_delay_ms is required. I updated AudioProcessing with setStreamDelayMs and getStreamDelayMs.