Local video is sometimes empty

devopvoid / webrtc-java

WebRTC for desktop platforms running Java

Apache License 2.0

248 stars 60 forks source link

Local video is sometimes empty #9

Closed vria closed 2 years ago

vria commented 3 years ago

Hi !

Rarely I get a strange bug that seems to be completely random. In essence, the video of a self camera is empty:

Screenshot from 2020-12-21 15-10-54

To reproduce a bug one should simply start a call.

Here are some details:

this happens once in 30-40 tests,
a camera lights up,
a distant peer receives a video form the camera,
localVideo VideoView appears and sized correctly (a rectangle that is appropriately sized)
I test mostly on Ubuntu 20 but I've seen this problem on Windows also

Have you ever encountered this bug?

devopvoid commented 3 years ago

Hey, that should be a JavaFX related bug. There is something wrong with the demo view implementation. I guess the frame arrives in the wrong thread. I will correct that.

vria commented 3 years ago

Great! It was my suspicion too, I tried to play with threads with no luck.

vria commented 3 years ago

I figured out the issue. This is because of clipping in VideoViewSkin

Rectangle clip = new Rectangle(newBounds.getWidth(), newBounds.getHeight());

Without it everything works well.