search

devosoft / Empirical

A library of tools for scientific software development, with emphasis on also being able to build web interfaces using Emscripten.
Other
86 stars 38 forks source link

Fix and enforce tidyness #449

Closed mmore500 closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #449 (b1ce62e) into master (48b56d2) will increase coverage by 0.93%. The diff coverage is 84.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   82.02%   82.96%   +0.93%     
==========================================
  Files         294      306      +12     
  Lines       33200    37356    +4156     
==========================================
+ Hits        27233    30992    +3759     
- Misses       5967     6364     +397
Impacted Files Coverage Δ
include/emp/Evolve/OEE.hpp 0.00% <0.00%> (ø)
include/emp/Evolve/StateGrid.hpp 0.00% <ø> (ø)
include/emp/Evolve/Systematics.hpp 93.37% <ø> (ø)
include/emp/Evolve/World_reflect.hpp 100.00% <ø> (ø)
include/emp/Evolve/World_select.hpp 96.41% <ø> (ø)
include/emp/Evolve/World_structure.hpp 94.53% <ø> (ø)
include/emp/base/MapProxy.hpp 90.00% <ø> (ø)
include/emp/base/_native_error_trigger.hpp 0.00% <0.00%> (ø)
include/emp/base/_assert_macros.hpp 31.03% <31.03%> (ø)
include/emp/base/always_assert_warning.hpp 64.28% <60.00%> (+4.28%) :arrow_up:
... and 216 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48b56d2...b1ce62e. Read the comment docs.

emilydolson commented 3 years ago

I think this seems like a great addition! These are very reasonable tidyness standards to enforce. My one question is how it interacts with #425.

mmore500 commented 3 years ago

@emilydolson great q! I had actually forgot about that pr. We had gotten hung up on trying to find a good GitHub action that ensured that we were compliant with the editorconfig! Now that we have tidy scripts, we’re back in business. I went ahead and merged that pr into this one because they’re so closely related.

mmore500 commented 3 years ago

I briefly looked at using https://github.com/editorconfig-checker/editorconfig-checker.python to check the editorconfig rules as part of our tidy routine, but we like to do bespoke space indentation (i.e., odd numbers of spaces etc. etc.) so much that it's not viable for our project. I'll go ahead and merge when things pass!

emilydolson commented 3 years ago

Sounds good assuming @mercere99 is good with it! (I didn't do an official review because I was assuming you wanted his okay on this)