devosoft / Empirical

A library of tools for scientific software development, with emphasis on also being able to build web interfaces using Emscripten.
Other
86 stars 38 forks source link

Seed random for deterministic BitVector tests #457

Closed mmore500 closed 3 years ago

mmore500 commented 3 years ago

Just saw a fluke failure in CI due to nondeterminism

-------------------------------------------------------------------------------
5: Test Randomize() and variants
-------------------------------------------------------------------------------
BitVector.cpp:377
...............................................................................

BitVector.cpp:491: FAILED:
  REQUIRE( one_counts[i] < 810 )
with expansion:
  814 (0x32e) < 810 (0x32a)

===============================================================================
codecov[bot] commented 3 years ago

Codecov Report

Merging #457 (2cba305) into master (d2e1659) will increase coverage by 0.00%. The diff coverage is 90.90%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   82.96%   82.96%           
=======================================
  Files         306      306           
  Lines       37356    37356           
=======================================
+ Hits        30993    30994    +1     
+ Misses       6363     6362    -1     
Impacted Files Coverage Δ
tests/bits/BitSet.cpp 99.41% <80.00%> (ø)
tests/bits/BitVector.cpp 100.00% <100.00%> (ø)
include/emp/Evolve/World_select.hpp 96.41% <0.00%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2e1659...2cba305. Read the comment docs.