search

devosoft / Empirical

A library of tools for scientific software development, with emphasis on also being able to build web interfaces using Emscripten.
Other
86 stars 38 forks source link

Lots of tests for `emp::String` appear to be disabled #496

Open mmore500 opened 11 months ago

mmore500 commented 11 months ago

See i.e., https://github.com/devosoft/Empirical/blob/fbf27dc43326e252d62ca094285662826d0293b0/tests/tools/String.cpp#L346

We should check if these functions have been removed and, if not, if they are broken.

mercere99 commented 11 months ago

emp::String was built in String.hpp based off of all of the functions in string_utils.hpp. I moved many of the string_util tests over, but some didn't apply cleanly. I do want to go through the rest more to see if any of them should be added, but I don't think it's critical. They weren't removed because of lack of passing or anything like that; they're still active in the string_utils.cpp tests.