search

devote / HTML5-History-API

HTML5 History API expansion for browsers not supporting pushState, replaceState
http://spb-piksel.ru
MIT License
1.02k stars 182 forks source link

Query strings in the URL breaks in IE8 and IE9 #61

Closed jameslnewell closed 9 years ago

jameslnewell commented 10 years ago

Results in https://dev.online4.nib.com.au/health-insurance/join/your-details?abc#/health-insurance/join/your-details?abc

devote commented 10 years ago

Hello, I can't open this URL

jameslnewell commented 10 years ago

The domain is only running locally on our individual dev machines.

I believe adding a query string to any URL that gets modified by the shim will achieve the same result. I can reproduce it in the example project that I created earlier today...

  1. Navigate to http://10.0.0.33:3000/page-1?abc
  2. Refresh the page

You'll get http://10.0.0.33:3000/page-1?abc#/page-1?abc and notice the "Page Index" is displayed instead of "Page #1".

devote commented 10 years ago

Ok, I will try to correct the mistakes and prepare tests this weekend...

Thanks!

devote commented 10 years ago

if you replace all window.location to a just location and add to the head a file var location = window.history.location || window.location; then this error can be avoided before.

jameslnewell commented 9 years ago

Thank you!