Closed simonrycroft closed 9 years ago
Hi, thanks for comment
I've done a little tweaking and I believe this would work just as well, without the use of eval:
eval
is needed for what would Google Closure Compiler did not delete this line when compiling
There is a solution:
var msie = global['execScript'] && (global['execScript']('var documentMsie/*@cc_on =1@*/;', 'JavaScript'), global.documentMsie);
Please check this solution, Thank you!
Hi,
Thank you! I'll check it as soon as I get into the office tomorrow.
Simon On 4 Nov 2014 18:07, "Dmitrii Pakhtinov" notifications@github.com wrote:
There is a solution:
var msie = global['execScript'] && (global['execScript']('var documentMsie/@cc_on =1@/;',), global.documentMsie);
Please check this solution, Thank you!
— Reply to this email directly or view it on GitHub https://github.com/devote/HTML5-History-API/issues/70#issuecomment-61686094 .
Okay, waiting for tomorrow.
Hi Dmitrii,
Unfortunately this causes an error in Chrome and possibly other browsers:
Uncaught ReferenceError: global is not defined
Si
On 4 November 2014 18:17, Dmitrii Pakhtinov notifications@github.com wrote:
Okay, waiting for tomorrow.
— Reply to this email directly or view it on GitHub https://github.com/devote/HTML5-History-API/issues/70#issuecomment-61687610 .
Very strange, I checked in chrome, no problems.
You simply change the line in 1136 ?
Sorry my mistake. I didn't realise we had an out of date version of history.js. No errors now. Thank you!
On 5 November 2014 14:10, Dmitrii Pakhtinov notifications@github.com wrote:
Very strange, I checked in chrome, no problems.
You simply change the line in 1136 ?
— Reply to this email directly or view it on GitHub https://github.com/devote/HTML5-History-API/issues/70#issuecomment-61811683 .
it's good
I add this solution to a release
Great stuff. Thanks for your help.
On 5 November 2014 15:01, Dmitrii Pakhtinov notifications@github.com wrote:
it's good
I add this solution to a release
— Reply to this email directly or view it on GitHub https://github.com/devote/HTML5-History-API/issues/70#issuecomment-61819738 .
Hi,
This line in history.js:
var msie = window['eval'] && eval("/_@ccon 1;@/");
causes a problem if the server sends a Content-Security-Policy header. JS execution is stopped and the console gives errors like this:
Refused to evaluate a string as JavaScript because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src 'self'
The use of eval is not permitted. More info here:
http://www.html5rocks.com/en/tutorials/security/content-security-policy/#eval-too
I've done a little tweaking and I believe this would work just as well, without the use of eval:
Thanks.