Build

[x] Check all dependencies
[x] ionic build -prod doesn't work with fullTemplateTypeCheck re-enabled
[x] npm run test doesn't work
[x] npm run e2e doesn't work
[x] Check if crypto libs work with prod build (this will not be a compile time error, but rather it won't work when trying to prepare a transaction)
[x] Check if project builds in the docker container
[x] <script src="assets/libs/blockies.min.js"></script> is not included in index.html anymore. Check if it's still needed.

Code

[x] Update ionic to 4.3.1
[x] Some pages still use NavController (eg. account-address)
[x] walletDeeplinkin app.component.ts has code commented out (pushing tx page in chrome extension)
[x] account-transaction-list has commented code in "presentEditPopover"
[x] sub-account-add.ts "prepareOriginate" not implemented yet
[x] sub-account-import.html "import-all" string with translated parameter is commented out
[x] sub-account-select.ts "goToDelegateSelection" not implemented
[x] Enable ProtocolSelectPageModule in components.module.ts
[x] swap.ts onDidDismiss uses protocolIdentifier.data. Shouldn't it be "protocolIdentifier"?
[x] In the swap.html, this line was changed: [(ngModel)]="exchangeAmount". Check if it still works
[x] add-account page has inconsistent navigation (info and mainProtocolIdentifier)
[ ] @devotebest scanner on scan-address.ts doesn't work (and not sure if sendAddressToParent callback will be executed)

[ ] No shadowed variables
[x] Check sentry error handler
[ ] Use async/await instead of promises (eg. alerts)
[ ] Use TS 2.7 features
[ ] Data service use TS 2.7
[ ] Scan-Sync page not used?
[ ] component-selector and directive-selector should use prefix airgap
[ ] Discuss if "DataResolverService" should be a Guard or a Service
[ ] Page transitions fire a lot of events (looking at the performance tab in Chrome). Is there a way to improve that?
[ ] Not a regression, was like that in Ionic 3 Animations are sometimes covering or not covering the previous page. Easy place to reproduce: When opening an account and then using "swipe to go back" slowly, you can see that the "header" of the transaction page overlays the chart on the portfolio screen.

[x] @AndreasGassmann Exchange screen input doesn't allow "."
[x] @devotebest prepare transaction page slider only has 2 steps, but should have 3.
[x] @devotebest Transaction detail sometimes does not include info like "fee", "amount", etc. This is probably related to the error TypeError: _co.transaction.fee.toNumber is not a function. (In '_co.transaction.fee.toNumber()', '_co.transaction.fee.toNumber' is undefined) on the transaction-list page.
[x] Text "FROM", "AMOUNT", on "transaction-confirm" and "transaction-detail" is too big.

[x] Extension build script does not work npm run extension:build:extension-only gives Error: Could not inject extension css!

[ ] @pascuin Buttons on the bottom are too close to the border on an iPhone X, there should be a bigger gap. So it's most likely not the right style.
[x] Edit popover on transaction list screen has an "empty space" below the 2 items.
[x] When importing a wallet (same device), the address gets generated and displayed, but the amount is only visible after touching the screen (probably related to ngZone).

[ ] If a deeplink enters the app, the page (eg. add coin) is shown behind modals, so the user doesn't know anything happened.
[ ] Sometimes the background around the search bar on the "add coin" page is transparent.
[ ] When scrolling (flicking) on the portfolio page and then selecting an account usually results in the scroll to stop, but the account will not be opened.

devotebest commented 5 years ago

we don't need . because we already have @download/blockies and myethewallet-blockies library.

devotebest commented 5 years ago

I updated about navcontroller, we will use navcontroller for only pop feature.

devotebest commented 5 years ago

ProtocolSelectPageModule is already enabled, so need to remove that.

devotebest commented 5 years ago

swap.ts onDidDismiss uses protocolIdentifier.data. Shouldn't it be "protocolIdentifier"?

I debugged out, ionic 4 returning data with object.data format. so used .data