search

devour-js / devour-client

Don't just consume your JSON API, Devour it...
https://www.npmjs.com/package/devour-client
ISC License
429 stars 89 forks source link

Add model to req object returned by get method #217

Closed solidgoldpig closed 4 years ago

solidgoldpig commented 4 years ago

What Changed & Why

Adds model to the request object returned by the get method to bring it line with other methods.

Also adds tests that confirm correct model is added to other methods.

Bug/Ticket Tracker

https://github.com/twg/devour/issues/216

solidgoldpig commented 4 years ago

Thanks @tijn and @auvipy . Any idea when this will make it into a new release?

khalid283 commented 4 years ago

@tijn release 2.1.1 has not pushed into npm.

tijn commented 4 years ago

@khalid283 oh, I'll see if I can quickly fix that. Thanks for the heads-up!

tijn commented 4 years ago

Oh, I obviously cannot since npmjs.com doesn't know me yet.

@Emerson or @Auspicus, seeing that you talked about this last year, could either of you perhaps grant me the rights to publish to npm? My username over there is tijn-jobport .

khalid283 commented 4 years ago

@Emerson Please give npmjs.com access to @tijn

Emerson commented 4 years ago

Ok! Invited to NPM. Sorry for the delay 👍

khalid283 commented 4 years ago

@tijn I hope npm now know you. can you please push the latest 2.1.1

tijn commented 4 years ago

@khalid283 yes. Done. (I hope 🤞)

I had some trouble with the publish script because I wanted to publish from the right git tag because the master branch is newer than v2.1.1 and well, that delayed stuff.

khalid283 commented 4 years ago

@tijn Thank you