search

devour-js / devour-client

Don't just consume your JSON API, Devour it...
https://www.npmjs.com/package/devour-client
ISC License
429 stars 90 forks source link

Upgrade jsonpointer, standard, and mocha #233

Closed tijn closed 2 years ago

tijn commented 2 years ago

What Changed & Why

My goal was to resolve this dependabot alert and while doing so I upgraded the standard package to the latest version. Then I ran npm run autofix to format the code according to the latest standards (this makes the PR huge; my apologies) and fixed the mocha configuration since it got updated too and its default configuration settings changed over time.

TLDR: I dragged a few libraries into the modern age and this introduced many small code changes.

auvipy commented 2 years ago

the code changes seems appropriate to me. btw don't we have any CI active? if not I want to start one

tijn commented 2 years ago

the code changes seems appropriate to me. btw don't we have any CI active? if not I want to start one

@auvipy we do! You can find two badges at the top of the readme file that link to this page on Travis and [this one for Snyk[(https://snyk.io/test/github/twg/devour). Travis got sold a few years ago to some company that is not doing much with it though. So I'm all for replacing it with another CI solution if you know a better one.

tomers commented 2 years ago

LGTM