devour-js / devour-client

Don't just consume your JSON API, Devour it...
https://www.npmjs.com/package/devour-client
ISC License
428 stars 90 forks source link

Support Axios 1.1.3 #243

Closed davycardinaal closed 1 year ago

davycardinaal commented 1 year ago

Priority

When your app uses Axios 1.1.3 and you assign this axios instance to devour-client, it crashes on the paramsSerializer implementation. Axios 1.1.3 has a breaking change for this method.

Screenshot

What Changed & Why

Before:

config.paramsSerializer = params => doSomethingWithParams(params)

After:

config.paramsSerializer = {
  serialize: params => doSomethingWithParams(params)
}

Testing

Bug/Ticket Tracker

Documentation

See the paramsSerializer documentation in https://github.com/axios/axios#request-config

In Progress/Follow Up

Legal/Security/Privacy

Third-Party

People

Mention people who would be interested in the changeset: Engineer(s) who wrote the old version: @tijn