search

devowlio / node-lame

LAME is an open-source encoder that encodes and decodes audio to the MP3 file format. For all MP3 needs a Node.js wrapper of the full LAME command line.
Other
82 stars 9 forks source link

Adding `artwork` meta option silently fails #28

Closed rhys-vdw closed 2 years ago

rhys-vdw commented 3 years ago

I just opened #27, but when I try to use meta.artwork the library just silently fails, apparently killing the entire process (the promise is neither resolved nor rejected:

    console.log("bout to " + outputMp3);
    await new Lame({
      output: outputMp3,
      bitrate: config.bitrate,
      meta: {
        artist: config.artist,
        album: config.album,
        title,
        year: config.year,
        track: discTrackNumber.toString(),
        genre: config.genre,
        artwork: config.artwork,
        "add-id3v2": true,
      } as any, // using any here to eliminate any strangeness from using my PR as a dependency
    })
      .setFile(wavFilePath)
      .encode();
bout to C:\Users\rhysv\Projects\steam-soundtrack-converter\dest\mp3\101 - Bossa No-va.mp3
bout to C:\Users\rhysv\Projects\steam-soundtrack-converter\dest\mp3\102 - Nancy's Theme.mp3
bout to C:\Users\rhysv\Projects\steam-soundtrack-converter\dest\mp3\103 - MegaMart Spirit.mp3

rhysv@DESKTOP-L5VJNBK MINGW64 ~/Projects/steam-soundtrack-converter (master)
jankarres commented 3 years ago

Thanks for the fix of the typings.

At https://github.com/devowlio/node-lame/blob/82dd8c75c2416ca2e97fcbdcb25a7d28981e2fa8/test/tests.js#L641 the tests run with a artwork. So I assume that it is not a problem with adding the artwork to the converted file.

Can you please provide a reproducible demo (repo) so I can check what is going wrong here?

jankarres commented 2 years ago

Since no reducible demo or further information has been provided more than six months after opening this ticket, I am closing this ticket.

rhys-vdw commented 2 years ago

Sorry about that @jankarres. Was in the back of my mind but I got side tracked.