search

devowlio / node-lame

LAME is an open-source encoder that encodes and decodes audio to the MP3 file format. For all MP3 needs a Node.js wrapper of the full LAME command line.
Other
81 stars 9 forks source link

Minor fixes and improvements #4

Closed deermichel closed 6 years ago

deermichel commented 6 years ago

Hey Jan, while using your library I stumbled across some issues that I fixed in this PR. However, I'm not completely sure about the redundant quotes... using lame 3.99.5 on Mac (installed via homebrew) I don't need them. If I include them, a song named Song123 would have the ID3 title tag 'Song123'. For convenience, there is now also an option to include an album artwork. Please make sure I got the tests and ts compilation right 😬 . Greetz, deermichel

jankarres commented 6 years ago

Thanks for your work. I published v1.0.5 just now.