search

devoxin / SharpLink

Lavalink wrapper for Discord.Net written in C#
MIT License
27 stars 6 forks source link

TotalShards in LLManagerConfig is unnecessary. #10

Closed SolarysDev closed 6 years ago

SolarysDev commented 6 years ago

LavaLinkManager's only constructor takes one DiscordSocketClient, which doesn't support sharding, yet you can configure the total shards in the LLManagerConfig.

Unless we're supposed to give each individual client its own manager, which defeats the point of TotalShards in the first place.

NovusTheory commented 6 years ago

Lavalink needs a client for each discord gateway connection and the point of Total Shards is that lavalink requires it's passed and yes if you shard with multiple programs (which big bots do) it doesn't make total shards pointless.

As per what you said in DAPI about not being able to pass a ShardedClient there isn't support for it yet because we'll need to iterate the clients and do work with multiple clients (creating multiple managers internally and other such)